Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug_fix: if only one port bind to the sg, then unbind the port to the sg, it will not enforce in port_group #3092

Merged
merged 1 commit into from
Jul 30, 2023

Conversation

lynn901
Copy link
Member

@lynn901 lynn901 commented Jul 30, 2023

…sg ,it will not enforce in port_group

What type of this PR

Examples of user facing changes:

  • Bug fixes
  • Docs

Which issue(s) this PR fixes:

Fixes #(issue-number)

WHAT

🤖 Generated by Copilot at 56417d4

Refactor security group controller logic and remove unnecessary check in syncSgLogicalPort function. This change simplifies the code and avoids potential confusion or errors in pkg/controller/security_group.go.

🤖 Generated by Copilot at 56417d4

syncSgLogicalPort
No need to check for nothing
Simpler code in fall

HOW

🤖 Generated by Copilot at 56417d4

  • Simplify and refactor the security group controller logic (link,

@zbb88888 zbb88888 merged commit 8821874 into kubeovn:master Jul 30, 2023
zbb88888 pushed a commit that referenced this pull request Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants